search

zerocracy / fbe

FactBase Extended (FBE) for the judges in judges-action and inside Baza
https://rubygems.org/gems/fbe
MIT License
3 stars 2 forks source link

select only resolved comments #80

Closed Suban05 closed 3 months ago

Suban05 commented 3 months ago

@yegor256 this pr fixes https://github.com/zerocracy/judges-action/issues/308 I think it is more logical to fix the Fbe.github_graph.resolved_conversations method, because this function should only return resolved conversations, but now it does not. Thus, we will not have to fix anything in judges-action, other than upgrading the fbe version.

yegor256 commented 3 months ago

@Suban05 thanks!

yegor256 commented 3 months ago

@rultor release, tag is 0.0.59

rultor commented 3 months ago

@rultor release, tag is 0.0.59

@yegor256 OK, I will release it now. Please check the progress here

rultor commented 3 months ago

@rultor release, tag is 0.0.59

@yegor256 Done! FYI, the full log is here (took me 24min)

0crat commented 3 months ago

@Suban05 Hey there! 👋 Thanks for your contribution, but it looks like we've got some room for improvement. You earned +4 points this time: +16 base, but we had to deduct points for missing code review and comments. Your 12 hits-of-code were a bit low too (-8 points). We bumped you up to the minimum 4 points to keep you going. Remember, more hits-of-code (aim for 20+) and getting your code reviewed with comments can really boost your score! Keep the contributions coming – you're doing great overall with a balance of +532!