code review comments are not the same as formal code review

zerocracy / judges-action

A GitHub Action that scans the entire repository and generates a Factbase for Zerocracy

https://zerocracy.github.io/judges-action/zerocracy.html

MIT License

12 stars 5 forks source link

code review comments are not the same as formal code review #298

Closed yegor256 closed 4 weeks ago

yegor256 commented 4 weeks ago

Look at this ticket: https://github.com/zerocracy/judges-action/pull/294 Here, only one formal code review was submitted (by @Suban05), while other two participants (@yegor256 and @Yegorov) only posted comments. However, the github-events.rb script created three pull-was-reviewed facts. This is a mistake, only one fact should have been created.

Suban05 commented 4 weeks ago

@yegor256 I can help

yegor256 commented 4 weeks ago

@Suban05 please, go ahead

yegor256 commented 4 weeks ago

@rultor release, tag is 0.0.48

rultor commented 4 weeks ago

@rultor release, tag is 0.0.48

@yegor256 OK, I will release it now. Please check the progress here

rultor commented 4 weeks ago

@rultor release, tag is 0.0.48

@yegor256 Done! FYI, the full log is here (took me 30min)