search

zerocrates / OaiPmhRepository

OAI-PMH repository plugin for Omeka
http://omeka.org/codex/Plugins/OaiPmhRepository
GNU General Public License v3.0
3 stars 15 forks source link

Empty collections #5

Closed Daniel-KM closed 9 years ago

Daniel-KM commented 10 years ago

Hi,

A patch to avoid exposition of empty collections.

Sincerely,

Daniel Berthereau Infodoc & Knowledge management

zerocrates commented 10 years ago

Is there a specific use case or issue in the background of this PR?

The spec specifically allows empty sets: "The set hierarchy of a repository may include sets that are empty."

Daniel-KM commented 10 years ago

Hi,

In a project, I use the plugin tree collection and I don't want that main empty collections become sets. This is an option, not a requirement, so admin may set it or not.

Sincerely,

Daniel Berthereau Infodoc & Knowledge management

zerocrates commented 9 years ago

Can you make a version of this PR (or a new PR) that just has the "Added an option to avoid exposition of empty collections." commit alone?

Since it's optional, I don't see any problem with merging, but at the moment the PR contains some unrelated changes.

Daniel-KM commented 9 years ago

Hi,

I rebased the commit.

Sincerely,

Daniel Berthereau Infodoc & Knowledge management