search

zerodahero / laravel-workflow

Use the Symfony Workflow component in Laravel
MIT License
197 stars 37 forks source link

Add `--with-metadata` support for workflow:dump command #97

Closed cfong63 closed 2 weeks ago

cfong63 commented 2 weeks ago

Hopefully its explained in the README changes.

Largely just exposing symfony's --with-metadata option for dumping workflow

cfong63 commented 2 weeks ago

Done and done, thanks for maintaining the project :)

cfong63 commented 2 weeks ago

Updated to fix the existing tests

cfong63 commented 2 weeks ago

🤦‍♂️ just learning now that symfony's metadata dumping has a 8.1 dependency.

I'm not versed in how to handle cross-version dependencies. Any quick thoughts? Simplest thing would be to skip this in php 8.0 test and bump the doco I'm guessing but that seems a bit hack-ish

zerodahero commented 2 weeks ago

🤦‍♂️ just learning now that symfony's metadata dumping has a 8.1 dependency.

I'm not versed in how to handle cross-version dependencies. Any quick thoughts? Simplest thing would be to skip this in php 8.0 test and bump the doco I'm guessing but that seems a bit hack-ish

I'm fine dropping support for PHP 8.0, it's dead now anyway. I think it's fair to bump this a major version to note that drop--so we can merge that in and I'll fix up the matrix before cutting the 6.0 release here.