zerodays / react-native-gen-ui

A Generative UI library for React Native.
https://www.npmjs.com/package/react-native-gen-ui
MIT License
78 stars 7 forks source link

Add support for synchronouos render functions #13

Closed matejm closed 7 months ago

matejm commented 7 months ago

Description of change

Fixes issue #12.

Why? Sometimes your tool simply displays some info and the requirement for async generators is irrelevant.

Discussion:

Should we also support synchronouos generators?

I think not as this could lead to tons of unexpected mistakes.

Should we also support async render functions without generators?

We have the capability to easily add the support, but maybe we should intentionally leave it out to actively encourage developers to use generators to show current state of tool processing.

Pull-Request Checklist

zigapk commented 7 months ago

Great! I'd only suggest changing the documentation slightly.

github-actions[bot] commented 7 months ago

:tada: This PR is included in version 1.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: