Add WebAuthN validator - Githubissues

KONFeature commented 9 months ago

Missing unit test, currently in the process of writing script to generate the different stuff required for the webauthn msg hash & signin

Sam-Scolari commented 9 months ago

@KONFeature Is this going to utilize the EIP-7212 precompile under the hood?

KONFeature commented 9 months ago

@KONFeature Is this going to utilize the EIP-7212 precompile under the hood?

Not yet, this is just a POC. Still a few stuff needing to be done here:

Adding a few unit test
Move the webauthn formatting stuff inside the validator directly (hidden behind a lib to make that clean)
Create a wrapper contract around the FCL.ecdsa_verify lib, that has a fallback method used to verify the sig, and call it verify the sig via this wrapper (this will make the contract rip7212 compliant), I need to check with FCL creator to be sure about that :)

And btw, this verification code isn't audited yet, if I remember correctly an audit is planned during Q1

KONFeature commented 9 months ago

Small update regarding last comment:

100% coverage on the webauthn validator reached
Cleaned up the webauthn formatting stuff (where I previously removed the revert in case of formatting error, now it's reverting properly, and can send a challengeOffset to uint256.max to bypass format check)
Encapsulated the P256 verifier inside a small wrapper accepting the same format as the EIP-7212, but the address of the validator would need to be changed once the RIP-7212 will be released, since this precompiled p256 will be available on the address 0x100 (so even with the daimo implementation, an address change would be needed)

And the FCL code as been audited by gnosis internal team once, thx to the Cometh team

zerodevapp / kernel