Only add default directives if `run` is present

zerodevx / svelte-img

High-performance responsive/progressive images for SvelteKit

https://zerodevx.github.io/svelte-img/

ISC License

300 stars 11 forks source link

Closed jspn-creative closed 1 year ago

jspn-creative commented 1 year ago

Closes #10
Previously, omitting the run directive on imported images would result in an error when they were used in regular <img> tags as the image's source.
As a quick solution, a ternary has been added to defaultDirectives to ensure that each URL includes a 'run' search parameter.
I've also included a basic test to ensure that imported images which don't include any query params (as is standard Svelte usage) return the path to the image.

zerodevx commented 1 year ago

Thanks so much for your contribution - just to let you know that I'll review as soon as possible, once I get a breather!

zerodevx commented 1 year ago

Hey, sorry for the wait - I too think this is good enough for now. Thanks once again for your contribution. 🙏