search

zerodevx / zero-md

Ridiculously simple zero-config markdown displayer
https://zerodevx.github.io/zero-md/
ISC License
437 stars 48 forks source link

Adapt example to pass options to Marked #105

Closed AlexandreDecan closed 8 months ago

AlexandreDecan commented 8 months ago

Hello,

Thanks for your nice library! I went into an issue when trying to pass options to Marked as explained in the documentation (see last section of https://zerodevx.github.io/zero-md/advanced-usage/). I consistently went into "render is not a function" when trying to use this example (maybe it's related to the fact I'm using zero-md as a module? I don't know). I'm not an expert in JS (not at all), but I found that the issue can be solved by delaying the call to render. I don't know why putting "defer" in

On another note, v2 will soon EOL and there could be significant changes in v3 (which I'm working on atm).

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

zerodevx commented 8 months ago

If you can use window.onload, you can use customElements: https://developer.mozilla.org/en-US/docs/Web/API/Window/customElements

Module or not doesn't matter.

AlexandreDecan commented 8 months ago

Oh, nice! There are so many things that have changed since I wrote my last js code more than 10 years ago :-)

I'll update the pr.

zerodevx commented 8 months ago

Thanks for your contribution! 🙏