search

zerodha / cppkiteconnect

C++ Kite Connect API library / SDK
Other
47 stars 22 forks source link

Revert "chore: switch mock_responses to submodule" #29

Closed bhumitattarde closed 3 years ago

bhumitattarde commented 3 years ago

Reverts zerodha/cppkiteconnect#28

Checks seem to be failing on main.

bhumitattarde commented 3 years ago

@rhnvrm CI checks fail because the submodule doesn't get pulled. This will require changes in workflow. Changes in mock responses mean values in tests will have to be changed as well. I tested on my local machine and most tests fail. Would you like to send a PR with these changes?

Also, previous mock_responses directory had a bin file for ticker testing as well. The submodule doesn't seem to have such a file.

rhnvrm commented 3 years ago

This was weird and surprising considering GitHub showed the tests to pass. https://github.com/zerodha/cppkiteconnect/runs/2983214316

CI checks fail because the submodule doesn't get pulled. This will require changes in workflow.

This isn't needed as we already have the with_submodules flag enabled in the workflow.

Changes in mock responses mean values in tests will have to be changed as well. I tested on my local machine and most tests fail. Would you like to send a PR with these changes?

I have sent it in #30

Also, previous mock_responses directory had a bin file for ticker testing as well. The submodule doesn't seem to have such a file.

Added in #30

Closing this in favor of #30, will do the patches there