search

zerodha / frappe-attachments-s3

A frappe app to upload file attachments in doctypes to s3.
Other
123 stars 143 forks source link

Why year/month/day? #33

Closed ddavidebor closed 3 years ago

ddavidebor commented 4 years ago

Hi,

Just a quick question. Why using year/month/day in the name of the attachment?

David

fahimalizain commented 4 years ago

Maybe an option to set it as root-folder/doctype/name/filename ?

I think the requirements for every one of us is going to be different 😕 Best expose a key_generator hook function so we could customize independently ?

ddavidebor commented 4 years ago

That would be great!

fahimalizain commented 4 years ago

@ddavidebor i made a PR this, Please check #35

ddavidebor commented 4 years ago

Do you have a working example of a function I can use?