Cannot get latest version: module contains a go.mod file, so module path should be github.com/zerodhatech/gokiteconnect/v3

KateGo520 commented 4 years ago

Background

The github.com/zerodhatech/gokiteconnect uses Go modules and the current release version is v3. And it’s module path is "github.com/zerodhatech/gokiteconnect", instead of "github.com/zerodhatech/gokiteconnect/v3". It must comply with the specification of "Releasing Modules for v2 or higher" available in the Modules documentation. Quoting the specification:

A package that has opted in to modules must include the major version in the import path to import any v2+ modules To preserve import compatibility, the go command requires that modules with major version v2 or later use a module path with that major version as the final element. For example, version v2.0.0 of example.com/m must instead use module path example.com/m/v2. https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher

Steps to Reproduce

GO111MODULE=on, run go get targeting any version >= v3.0.0 of the zerodhatech/gokiteconnect:

$ go get github.com/zerodhatech/gokiteconnect@v3.0.0
go: finding github.com/zerodhatech/gokiteconnect v3.0.0
go: finding github.com/zerodhatech/gokiteconnect v3.0.0
go get github.com/zerodhatech/gokiteconnect@v3.0.0: github.com/zerodhatech/gokiteconnect@v3.0.0: invalid version: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v3

SO anyone using Go modules will not be able to easily use any newer version of zerodhatech/gokiteconnect.

Solution

1. Kill the go.mod files, rolling back to GOPATH.

This would push them back to not being managed by Go modules (instead of incorrectly using Go modules). Ensure compatibility for downstream module-aware projects and module-unaware projects projects

2. Fix module path to strictly follow SIV rules.

Patch the go.mod file to declare the module path as github.com/zerodhatech/gokiteconnect/v3 as per the specs. And adjust all internal imports. The downstream projects might be negatively affected in their building if they are module-unaware (Go versions older than 1.9.7 and 1.10.3; Or use third-party dependency management tools, such as: Dep, glide,govendor…).

If you don't want to break the above repos. This method can provides better backwards-compatibility. Release a v2 or higher module through the major subdirectory strategy: Create a new v3 subdirectory (github.com/zerodhatech/gokiteconnect/v3) and place a new go.mod file in that subdirectory. The module path must end with /v3. Copy or move the code into the v3 subdirectory. Update import statements within the module to also use /v3 (import "github.com/zerodhatech/gokiteconnect/v3/…"). Tag the release with v3.x.y.

3. Suggest your downstream module users to use hash instead of a version tag.

If the standard rule of go modules conflicts with your development mode. Or not intended to be used as a library and does not make any guarantees about the API. So you can’t comply with the specification of "Releasing Modules for v2 or higher" available in the Modules documentation. Regardless, since it's against one of the design choices of Go, it'll be a bit of a hack. Instead of go get github.com/zerodhatech/gokiteconnect@version-tag, module users need to use this following way to get the zerodhatech/gokiteconnect: (1) Search for the tag you want (in browser) (2) Get the commit hash for the tag you want (3) Run go get github.com/zerodhatech/gokiteconnect@commit-hash (4) Edit the go.mod file to put a comment about which version you actually used This will make it difficult for module users to get and upgrade zerodhatech/gokiteconnect.

*[]** You can see who will be affected here: [6 module users, e.g., sp98/mm-analyser, sivamgr/mercury, mridul-sahu/zerodha-trading] https://github.com/search?q=zerodhatech%2Fgokiteconnect+filename%3Ago.mod&type=Code

Summary

You can make a choice to fix DM issues by balancing your own development schedules/mode against the affects on the downstream projects.

For this issue, Solution 2 can maximize your benefits and with minimal impacts to your downstream projects the ecosystem.

References

KateGo520 commented 4 years ago

@VarunBatraIT @rhnvrm Could you help me review this issue? Thx :p

KateGo520 commented 4 years ago

@rhnvrm Thanks for your feedback.

KateGo520 commented 4 years ago

Close this issue via commit eba0269

zerodha / gokiteconnect