search

zerodha / phpkiteconnect

The official PHP client library for the Kite Connect trading APIs
MIT License
43 stars 30 forks source link

feat: refactor( added Guzzle HTTP client, Unit test and other chores) #15

Closed ranjanrak closed 3 years ago

ranjanrak commented 3 years ago

This PR includes below addition/changes:

  1. Added Guzzle HTTP client instead of current Curl.
  2. Refactor all required functions to accommodate HTTP client change.
  3. Added Unit test using PHPUnit.
  4. Added mock data for the unit tests.
pushpak1300 commented 3 years ago

I guess you have added vendor files also

ranjanrak commented 3 years ago

Missed adding the Vendor file under .gitignore, in this branch. I will rebase and fix this tomorrow. Done

pushpak1300 commented 3 years ago

Still vendor files are visible

ranjanrak commented 3 years ago

@pushpak1300 Vendor files had polluted the git tree. The above push should make it somewhat better. You can go through the changes. If everything looks good, we will make it available over the composer and plan the release.

Can you comment on feasibility regarding the addition of the WebSocket client as well? Ratchet looks good :)

pushpak1300 commented 3 years ago

If possible, can you comment on feasibility regarding the addition of the WebSocket client as well? Ratchet looks good :)

Yes, I have used Ratchet in the past and it's a really good library to work with WebSockets

pushpak1300 commented 3 years ago

Looks Good @ranjanrak 👍🏼

ranjanrak commented 3 years ago

Ref #16