Closed techie-subhadeep closed 2 years ago
urljoin produced un-intuitive joins for example
from urllib.parse import urljoin >>> urljoin('some', 'thing') 'thing' >>> urljoin('http://some', 'thing') 'http://some/thing' >>> urljoin('http://some/more', 'thing') 'http://some/thing' >>> urljoin('http://some/more/', 'thing') # just a / after 'more' 'http://some/more/thing' urljoin('http://some/more/', '/thing') 'http://some/thing'
to simplify the final URL generation process, it is proposed to replaced urljoin with simple string concatenation
The reason we do this is that we take the root URL from the user which can end with /. So in this case full URL will have double forward slash.
root
/
urljoin produced un-intuitive joins for example
to simplify the final URL generation process, it is proposed to replaced urljoin with simple string concatenation