search

zerodha / pykiteconnect

The official Python client library for the Kite Connect trading APIs
MIT License
981 stars 469 forks source link

fix: Datetime module raises oserror on windows #48

Closed joeirimpan closed 6 years ago

joeirimpan commented 6 years ago

datetime.fromtimestamp uses time.localtime behind the scenes. Python time module is a c extension which depends on os.

Behaviour: Invalid datetime epoch raise oserror on windows but raises valueerror on macos/linux flavours

codecov-io commented 6 years ago

Codecov Report

Merging #48 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   77.12%   77.12%           
=======================================
  Files           3        3           
  Lines         306      306           
  Branches       37       37           
=======================================
  Hits          236      236           
  Misses         62       62           
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f96696e...dd742d3. Read the comment docs.