Closed RudyAramayo closed 11 years ago
There are two issues with the current version.
One is within mach_inject, check this out, it works for me: https://github.com/rentzsch/mach_inject/issues/5
The other is (surprise!) that Finder has changed. Fortunately they are only method signature changes so the fix is straightforward. I can't post the fix now though, for Apple's beta software NDA.
Good job, stackbear!
I'm very pleased to hear that it will be easy to fix to work on 10.9. Thank you for your research, now waiting for the official release of 10.9.
No problem. This is the least I can do. I really appreciate you put the whole thing together at the first place.
Hopefully I can check in the fix in a month or so.
Hi @stackbear , would you be able to post the fix now that 10.9 is out ?
Dumping the headers of Finder 10.9, it seems that the signatures for overlay icons are the same except for some added functions that do tagging. Were you able to get overlay icons changed as well ?
I would wish to. My day job is keeping me quite busy for the time being unfortunately.
I added support for Mavericks. Now everything should work.
@zerodivisi0n , I'm trying to get the overlay icons work on Mavericks. The old cold I was injecting no longer works. How do you systematically find out what function to intercept ? Have you had success with overlay icons on Mavericks ?
Finder crashing in 10.9. Not sure what is going on, but I have the mach_inject and finder updates for Mavericks. Any insight as to what the issue could be? Been looking into it for a few days already. Thanks.
Process: Finder [74937] Path: /System/Library/CoreServices/Finder.app/Contents/MacOS/Finder Identifier: com.apple.finder Version: 10.9.4 (10.9.4) Build Info: Finder_FE-885004002000000~1 Code Type: X86-64 (Native) Parent Process: launchd [295] Responsible: Finder [74937] User ID: 503
Date/Time: 2014-09-25 12:33:06.645 -0500 OS Version: Mac OS X 10.9.4 (13E28) Report Version: 11 Anonymous UUID: BEC96EC5-C4EE-FB6E-8435-F174D30DC1AE
Sleep/Wake UUID: 119571B3-DD81-49D6-87E9-9D1DC2E02AC1
Crashed Thread: 6
Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: EXC_I386_GPFLT
External Modification Warnings: Thread creation by external task.
Thread 0:: Dispatch queue: com.apple.main-thread 0 libsystem_kernel.dylib 0x00007fff83f55a1a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fff83f54d18 mach_msg + 64 2 com.apple.CoreFoundation 0x00007fff8d770f15 CFRunLoopServiceMachPort + 181 3 com.apple.CoreFoundation 0x00007fff8d770539 CFRunLoopRun + 1161 4 com.apple.CoreFoundation 0x00007fff8d76fe75 CFRunLoopRunSpecific + 309 5 com.apple.HIToolbox 0x00007fff85ec7a0d RunCurrentEventLoopInMode + 226 6 com.apple.HIToolbox 0x00007fff85ec77b7 ReceiveNextEventCommon + 479 7 com.apple.HIToolbox 0x00007fff85ec75bc _BlockUntilNextEventMatchingListInModeWithFilter + 65 8 com.apple.AppKit 0x00007fff86ef424e _DPSNextEvent + 1434 9 com.apple.AppKit 0x00007fff86ef389b -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 122 10 com.apple.AppKit 0x00007fff86ee799c -[NSApplication run] + 553 11 com.apple.AppKit 0x00007fff86ed2783 NSApplicationMain + 940 12 com.apple.finder 0x0000000104111730 0x10410b000 + 26416 13 libdyld.dylib 0x00007fff8c7465fd start + 1
Thread 1:: Dispatch queue: com.apple.libdispatch-manager 0 libsystem_kernel.dylib 0x00007fff83f5a662 kevent64 + 10 1 libdispatch.dylib 0x00007fff8eaaf421 _dispatch_mgr_invoke + 239 2 libdispatch.dylib 0x00007fff8eaaf136 _dispatch_mgr_thread + 52
Thread 2: 0 libsystem_kernel.dylib 0x00007fff83f59e6a __workq_kernreturn + 10 1 libsystem_pthread.dylib 0x00007fff895c9f08 _pthread_wqthread + 330 2 libsystem_pthread.dylib 0x00007fff895ccfb9 start_wqthread + 13
Thread 3: 0 libsystem_kernel.dylib 0x00007fff83f59e6a __workq_kernreturn + 10 1 libsystem_pthread.dylib 0x00007fff895c9f08 _pthread_wqthread + 330 2 libsystem_pthread.dylib 0x00007fff895ccfb9 start_wqthread + 13
Thread 4: 0 libsystem_kernel.dylib 0x00007fff83f59e6a __workq_kernreturn + 10 1 libsystem_pthread.dylib 0x00007fff895c9f08 _pthread_wqthread + 330 2 libsystem_pthread.dylib 0x00007fff895ccfb9 start_wqthread + 13
Thread 5: 0 libsystem_kernel.dylib 0x00007fff83f55a1a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fff83f54d18 mach_msg + 64 2 com.apple.CoreFoundation 0x00007fff8d770f15 CFRunLoopServiceMachPort + 181 3 com.apple.CoreFoundation 0x00007fff8d770539 CFRunLoopRun + 1161 4 com.apple.CoreFoundation 0x00007fff8d76fe75 CFRunLoopRunSpecific + 309 5 com.apple.AppKit 0x00007fff8709405e _NSEventThread + 144 6 libsystem_pthread.dylib 0x00007fff895c8899 _pthread_body + 138 7 libsystem_pthread.dylib 0x00007fff895c872a _pthread_start + 137 8 libsystem_pthread.dylib 0x00007fff895ccfc9 thread_start + 13
Thread 6 Crashed: 0 libsystem_c.dylib 0x00007fff8e6864a1 __xvprintf + 106
Thread 6 crashed with X86 Thread State (64-bit): rax: 0x00000001047a5824 rbx: 0x00007fff73a30002 rcx: 0x00007fff73a30940 rdx: 0x00007fff73a314a0 rdi: 0xffffffffffffffff rsi: 0x0000000000000000 rbp: 0x00000001047a5e04 rsp: 0x00000001047a5804 r8: 0x00000001047a9c1d r9: 0x00000001047a5ef4 r10: 0x0000000000000000 r11: 0x0000000000000246 r12: 0x000000000000000a r13: 0x0000000000000000 r14: 0xffffffffffffffff r15: 0x00007fff73a314a0 rip: 0x00007fff8e6864a1 rfl: 0x0000000000010202 cr2: 0x00000001047a4050
Logical CPU: 0 Error Code: 0x00000000 Trap Number: 13
Binary Images:
0x10410b000 - 0x1045d9ff9 com.apple.finder (10.9.4 - 10.9.4) <1CEEB00A-B22D-34DA-ABDB-EC5419F308A4> /System/Library/CoreServices/Finder.app/Contents/MacOS/Finder
0x104927000 - 0x10492efff com.apple.SyncedDefaults (1.3 - 91.30.1) <26F0AD10-86CC-31A4-899C-097269680E05> /System/Library/PrivateFrameworks/SyncedDefaults.framework/SyncedDefaults
0x109c54000 - 0x109c54fec +cl_kernels (???) <1C6ACF25-B6FC-49C5-8E86-31FC9D280BE4> cl_kernels
0x109c5b000 - 0x109c5cfef +cl_kernels (???) <59E92038-BDA4-4148-B0A4-0F272FFF9607> cl_kernels
0x109c64000 - 0x109c65fee +cl_kernels (???)
External Modification Summary: Calls made by other processes targeting this process: task_for_pid: 4 thread_create: 2 thread_set_state: 0 Calls made by this process: task_for_pid: 0 thread_create: 0 thread_set_state: 0 Calls made by all processes on this machine: task_for_pid: 112248 thread_create: 128 thread_set_state: 8323
VM Region Summary: ReadOnly portion of Libraries: Total=254.2M resident=128.3M(50%) swapped_out_or_unallocated=125.9M(50%) Writable regions: Total=257.4M written=17.2M(7%) resident=88.2M(34%) swapped_out=8K(0%) unallocated=169.3M(66%)
REGION TYPE VIRTUAL =========== ======= CG backing stores 11.6M CG image 9.9M CG raster data 224K CG shared images 244K CoreAnimation 10.3M CoreImage 48K CoreServices 1556K Foundation 4K IOKit 43.7M IOKit (reserved) 4K reserved VM address space (unallocated) Kernel Alloc Once 8K MALLOC 160.7M MALLOC (admin) 32K Memory Tag 240 4K Memory Tag 241 116K Memory Tag 242 12K Memory Tag 250 236K Memory Tag 251 8K OpenCL 128K OpenGL GLSL 1664K STACK GUARD 56.0M Stack 10.1M VM_ALLOCATE 16.7M DATA 50.4M IMAGE 528K LINKEDIT 68.5M TEXT 185.8M __UNICODE 544K mapped file 61.9M shared memory 68K =========== ======= TOTAL 690.8M TOTAL, minus reserved VM space 690.8M
I know its only developer preview 2 but it is failing on the injection command... not so much the injection methods... but the actual injection of a basic log statement is failing...
Ill try to find the time to discover why... together we can all get this resolved!