zerodogg / mussort

Moved to GitLab
https://gitlab.com/zerodogg/mussort
GNU General Public License v3.0
5 stars 2 forks source link

mussort doesn't support non-Unix filesystems (VFAT et.al.) #5

Closed fedelibre closed 8 years ago

fedelibre commented 10 years ago

Just discovered your great software, thank you! I got this error:

Rename: f10877624.mp3 -> John_Renbourn/The_Black_Balloon/04-John_Renbourn-Medley:_The_Mist_Covered_Mountains_of_HomeThe_OrphanTarboulton.mp3
Error: Unable to move /media/SAMSUNG/audio/f10877624.mp3 to /media/SAMSUNG/audio/John_Renbourn/The_Black_Balloon//04-John_Renbourn-Medley:_The_Mist_Covered_Mountains_of_HomeThe_OrphanTarboulton.mp3: File o directory non esistente

It's because the : in the title tag? It should be escaped with \ when the file name is called? I see that bash does this trick automatically:

$ ls test\:colon.txt 
test:colon.txt

Here's some more information:

$ mussort --fileinfo audio/f10877624.mp3
Using cache from /home/fede/.mussort-cache
File information for /media/SAMSUNG/audio/f10877624.mp3:
Title: Medley:_The_Mist_Covered_Mountains_of_HomeThe_OrphanTarboulton
SetNo: {};
Ext: mp3
Album: The_Black_Balloon
Band: John_Renbourn
Track: 4
$ id3v2 -l audio/f10877624.mp3
id3v1 tag info for audio/f10877624.mp3:
Title  : Medley: The Mist Covered Mount  Artist: John Renbourn                 
Album  : The Black Balloon               Year: 1989, Genre: Unknown (255)
Comment:                                 Track: 4
id3v2 tag info for audio/f10877624.mp3:
TALB (Album/Movie/Show title): The Black Balloon
TPE1 (Lead performer(s)/Soloist(s)): John Renbourn
TCON (Content type): Acoustic Guitar (255)
TIT2 (Title/songname/content description): Medley: The Mist Covered Mountains of Home/The Orphan/Tarboulton
TRCK (Track number/Position in set): 4
TYER (Year): 1989
MCDI (Music CD identifier):  (unimplemented)
fedelibre commented 10 years ago

Yes, I confirm. I renamed the title tag of that song and now mussort is working again. At least until I hit another colon in a tag...

zerodogg commented 10 years ago

You're correct in assuming that the colon is the problem, it's not something with escaping though.

I assume /media/SAMSUNG/audio is a mounted media device? If so it's likely on some non-Unix filesystem (VFAT or similar), which doesn't support colons in filenames (among other limitations). mussort assumes a Unix filesystem, and doesn't filter filenames for use on non-Unix filesystems

It probably ought to detect it though and do additional filtering on these filesystems, I'll look into it.

fedelibre commented 10 years ago

Yes, you are right: it's EXFAT.