zeroeightysix / KAMI

Minecraft utility mod aimed at anarchy servers
Other
241 stars 73 forks source link

Optifabric Incompatible with KAMI #248

Open humboldt123 opened 3 years ago

humboldt123 commented 3 years ago

Describe the bug Optifabric and Optifine for 1.16.3 do not work with KAMI

To Reproduce Steps to reproduce the behavior: Launch minecraft with optifabric optifine and kami for 1.16.2

Expected behavior Minecraft launches without errors

Logs

[11:23:53] [main/INFO]: Loading for game Minecraft 1.16.3
[11:23:54] [main/INFO]: [FabricLoader] Loading 11 mods: minecraft@1.16.3, kami@1.16.3-sep, mm@2.1, fabric-resource-loader-v0@0.3.1+facf3bbf95, multiconnect-api@1.3.19, fiber@0.24.0-dev, org_jetbrains_kotlin_kotlin-reflect@1.4.0, multiconnect@1.3.19, fabricloader@0.9.3+build.207, optifabric@1.6.4, org_jetbrains_kotlin_kotlin-stdlib@1.4.0
[11:23:54] [main/INFO]: SpongePowered MIXIN Subsystem Version=0.8.1 Source=file:/C:/Program%20Files/MultiMC/libraries/net/fabricmc/sponge-mixin/0.8.1+build.21/sponge-mixin-0.8.1+build.21.jar Service=Knot/Fabric Env=CLIENT
[11:23:54] [main/WARN]: Error loading class: baritone/command/defaults/ComeCommand (java.lang.ClassNotFoundException: baritone/command/defaults/ComeCommand)
[11:23:54] [main/WARN]: @Mixin target baritone.command.defaults.ComeCommand was not found kami.mixins.json:MixinComeCommand
[11:24:06] [main/INFO]: [OptiFine] (Reflector) Field not found: World.tileEntitiesToBeRemoved
[11:24:07] [main/ERROR]: Critical injection failure: LVT in net/minecraft/class_757::method_3188(FJLnet/minecraft/class_4587;)V has incompatible changes at opcode 427 in callback net/minecraft/class_757::renderWorld.
Expected: [Z, Lnet/minecraft/class_4184;, Lnet/minecraft/class_4587;, Lnet/minecraft/class_1159;]
   Found: [Z, Lnet/minecraft/class_4184;, Lnet/minecraft/class_4587;]

Environment I built kami myself on this pr: https://github.com/zeroeightysix/KAMI/pull/247

Additional context I am using MultiMC

5HT2 commented 3 years ago

Use Mineral mods, optifabric is a hacky solution to a legacy program

humboldt123 commented 3 years ago

I want to use an optifine resource pack.

5HT2 commented 3 years ago

There's connected texture mods for fabric that are compatible with Optifines format

5HT2 commented 3 years ago

https://github.com/Nuclearfarts/connected-block-textures/

humboldt123 commented 3 years ago

I specifically want a mod that lets me change the colours of leaves with an optifine resource pack, I can't think of any other mods that are compatible with KAMI that do this,

5HT2 commented 3 years ago

I just linked one ...

5HT2 commented 3 years ago

Oh you mean biome color resource packs. Well that should be supported

humboldt123 commented 3 years ago

Connected block textures doesn't work either. log.txt

humboldt123 commented 3 years ago

Wouldn't it just be better to fix the incompatibility in the first place rather than just "don't use optifine"?

5HT2 commented 3 years ago

The proper solution would be to use a proper mod for said feature.

humboldt123 commented 3 years ago

Well optifine has all the features and both mods are incompatible.

5HT2 commented 3 years ago

I'm just saying that optifabric is a hacky solution to get a legacy mod working on fabric. Not saying this shouldn't be fixed, I'm saying there's better solutions

humboldt123 commented 3 years ago

I'm saying there's better solutions

The mod you suggested doesn't work either.

zeroeightysix commented 3 years ago

Duplicates #225, but this one has more info so I'm closing that one.

not-ivy commented 3 years ago

I specifically want a mod that lets me change the colours of leaves with an optifine resource pack, I can't think of any other mods that are compatible with KAMI that do this,

@humboldt123 Colormatic

Titaniumtown commented 3 years ago

Any progress on this? I really want to be able to use optifabric.

JerryWester commented 3 years ago

Dead mod, there are alternatives available. If you're looking for FPS boost, wait for sodium compat.

JerryWester commented 3 years ago

If you want a list of potential alternatives, here ya go: https://gist.github.com/LambdAurora/1f6a4a99af374ce500f250c6b42e8754

Titaniumtown commented 3 years ago

Dead mod, there are alternatives available. If you're looking for FPS boost, wait for sodium compat.

There is an active fork of optifabric that works with 1.16.4 without any issues (except for KAMI), and I couldn't get sodium working. My fps is super low without either sodium or optifine, so either is needed in my case.

JerryWester commented 3 years ago

Sodium works fine on my machine without ESP