search

zerofall / EZStorage

Storage: Simplified
MIT License
13 stars 5 forks source link

Taking an item out of EZ Storage when player's inventory is full crashes server #39

Open Nonsanity opened 8 years ago

Nonsanity commented 8 years ago

Taking an item out of EZ Storage when player's inventory is full will crash a server.

To reproduce, fill up your inventory and click on an item in the controller to remove it.

Nonsanity commented 8 years ago

Actually, it seems the inventory doesn't need to be full.

The crashlog has java.util.HashMap$HashIterator.nextNode as the culprit, so somewhere the mod is possibly walking off the end of the map.

At a guess, I'd look for a situation where a map is being iterated over and altered at the same time. That could cause the bounds of the iterator to become invalid. But, that's just a wild guess. :)