Crafting bug fixes

[Draylar]

Fixed #68 , #59 , and #67 .

Next up is #63, but I don't have enough time to fix it tonight. Also going to do a bit of refactoring on variable/method names and spacing.

I should also mention #62 was fixed in my first PR last month, so it can be closed. Thanks!

[Draylar]

Hi sb-- I'm not sure how much you're active on GitHub, but I would love to help out more with bug fixes and uploading them in a faster manner. I'm guessing you and zero have mostly moved on considering the lack of patches (which is fine, of course).

I could make a wiki and document the project more, but I'm not sure how often you're on to accept pull requests as well as upload release jars. Perhaps I could make an official "new maintainer fork", and you could link to it on the main CurseForge page so that I could upload release jars as soon as I get bugs squashed? That would make it easier for me, who wants to send out releases faster, and you, who wouldn't have to accept all my pull requests. Just something to think about!

edit: not to say that I've really done anything so far besides changing a few lines of code, but at the least I can certainly fix the rest of the issues and add a better wiki.

[DatrixTHLK]

Thanks for the response at least.

[Draylar]

Just added a few more commits to the PR-- now fixes issue #63.

As mentioned in the issue, the problem was that when a user shift clicked out of an EZStorage2 machine without inventory space, the mod would attempt to put the items into the player inventory, and put them back into the machine if the player's inventory was full. This caused issues when the storage block was removed because it would try to send the items back only to find a full (or 0 inventory space) block.

I figured the best way around this was to block the storage access if the user's inventory was full. This worked great until I realized it also blocked the user from picking up an item to craft with [if their inventory was full]. Just added a quick commit to fix this as well.

The 'feel' of the system is now almost identical to AE2, although right/left clicks might need a bit of work.

[zerofall]

I am open to the possibility of bringing on somebody new to help maintain the mod. I’m out of town this weekend, but I’ll take a closer look at this on Monday and get back to you to follow up and continue this conversation.

On Oct 11, 2018, at 6:39 PM, Samuel R notifications@github.com wrote:

Just added a few more commits to the PR-- now fixes issue #63.

As mentioned in the issue, the problem was that when a user shift clicked out of an EZStorage2 machine without inventory space, the mod would attempt to put the items into the player inventory, and put them back into the machine if the player's inventory was full. This caused issues when the storage block was removed because it would try to send the items back only to find a full (or 0 inventory space) block.

I figured the best way around this was to block the storage access if the user's inventory was full. This worked great until I realized it also blocked the user from picking up an item to craft with [if their inventory was full]. Just added a quick commit to fix this as well.

The 'feel' of the system is now almost identical to AE2, although right/left clicks might need a bit of work.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[kilometers]

Any progress on this? We love EZStorage on our server, but it feels incomplete without your clever crafting feature.

[alfuken]

@zerofall hi, are you back to the town yet? :)

[DatrixTHLK]

Oh well...

Edit (5/8/2019): I'm guessing he isn't on vacation anymore and he isn't responding...I'll consider this mod abandoned at this point until futher notice. No offense. You made a valiant effort @Draylar I'm not faulting you for that. If anything you should be commended for taking the opportunity to want to work on this. :) Maybe it's time you try to make a mod similar to this or fork this. I don't know just spit-balling right now. Would love to see what you'd make if you did. Keep it up!

Regards,

DatrixTHLK/PoisonShark

[Draylar]

I've moved on from Forge in favor of Fabric; may make a similar mod in the future for the latter. Thanks for keeping with me :)

[DatrixTHLK]

I'd use it if you did, but I've moved on to 1.14.4. You're welcome!