Hagen-002

[hagen-git]

• Make define switch names 'active', fix a few typo's, clarify some statements.
• Refactor LED dimming (and use lower minimum).
• Refactor LED table, change some characters (e.g. 't').
• Refactor ds1302.c (ds_int2bcd() et al.).
• Slow down alarm indicator flash frequency.
• Move12h/24h handling to display (output) only (see CONF_12H, the DS1302 internally works on 24h).

The original code was already very useful. In order to understand I refactored it. For my purposes, and to test a few theories, I changed a few little things. Enjoy!

[zerog2k]

Hi @hagen-git thanks for the contribution! However, before committing this to main branch, I would request that you cleanup the commit history a bit. (You may be able to accomplish this through a git interactive rebase, and resubmitting a PR.) Please ensure related, functional changes are grouped into individual, meaningful commits, and cosmetic (whitespace/indentation/formatting) changes are grouped separately into their own related commits.

This helps ensure a clean, meaningful commit history, so future developers can understand the progression of changes over time.

Here's an article which touches on these things. https://www.freecodecamp.org/news/git-best-practices-commits-and-code-reviews/ (I do need to write up a CONTRIBUTING doc for this repo ...)

Thanks, Jens