zeroheight / library-symbol-replacer

Sketch plugin to replace symbols in an existing documents with library symbols 💎 📚
MIT License
190 stars 6 forks source link

Plugin not preserving overrides #2

Closed dave-hawkins closed 6 years ago

dave-hawkins commented 7 years ago

Hey, would love to use this plugin but getting a bit of an issue.

Can you offer any better insight into why if my symbols are both named the exact same thing, the overrides are not being preserved?

It finds the two instances I have, overwrites the symbol, but doesn't preserve my overrides in the process.

Will happily provide source files if that helps.

dave-hawkins commented 7 years ago

Just a bit of further testing:

Abstracting the symbols to a new sketch document and then running the plugin makes it work, but pasting the newly Library-d symbols back into my working document reverts them back to the un-libraried one. 🙈

robintindale commented 6 years ago

erf - sorry Sketch symbols are very temperamental 😢 Yes source files are always helpful :) I have a few test cases already, so that might be enough already when I get time to bash my head against them

dave-hawkins commented 6 years ago

Certainly not your fault.. seems a big oversight on sketch's point of view not to offer this ability natively. I managed to fix it finally by abstracting them into a new document then bringing them over in batches, but nothing seemed to work when i tried the whole doc.. feel free to close this issue for now and thanks for the hard work as you definitely saved me a few hours :)