zerokent86 / myTipTool

0 stars 0 forks source link

Thanks! #1

Open coderschoolreview opened 8 years ago

coderschoolreview commented 8 years ago

Thanks for your submission. Everything looks good with that. We'll review it and get back to you soon :)

minhchau273 commented 8 years ago

👍 Congratulation on finishing the Tip Calculator. Your app looks good.

Some small comments:

zerokent86 commented 8 years ago

Thanks Chau for your comments! I missed the data validation and the truncated display, my bad :(. For remembering old amount, I have implemented the 10 minutes constraint with this code: if timeInterval < 600{....} // namely if the elapsed time is < 10 minutes, load the old amount. I tested this feature again, seemed working for me. Can you put more description for the issue you have had there? Thank you very much for your support!