Open iamdefinitelyahuman opened 5 years ago
In working on #20 I've discovered that some of the tests are broken because of breaking changes in Brownie. Along with a cleanup, the more important task is just to ensure that all tests are passing!
Marking this issue as high priority and adding it to the requirements to open source the repo.
Contracts and methods have been renamed per #21 but the overall structure of the tests is still lacking, and some of the name changes may have just made things even messier.
The Issues
conftest.py
files are sometimes 3 folders deep, and individual tests declare their own fixturesaccounts
are being imported that could instead be retrieved as fixturesHow to Fix
tests/conftest.py
explaining what each fixture doesconftest.py
files at most 1 subfolder beyondtests
README.md
files to make tests easier to navigateThe ultimate goal is to make the test suite understandable even to someone who has never seen ZAP before, so it can be linked to from the Brownie docs as an example of what is possible.