Closed iamdefinitelyahuman closed 4 years ago
Regardless of which address tokens are minted to, the Transfer and TransferRange events that fire will show them as being minted to msg.sender:
Transfer
TransferRange
msg.sender
https://github.com/iamdefinitelyahuman/ZAP-Tech/blob/62f8434e9033a930f61e3ddb968a5ecd227ef535/contracts/NFToken.sol#L373-L374
Change msg.sender to _owner in the above lines, and maybe add some unit tests to check the correctness of the events being fired.
_owner
The Issue
Regardless of which address tokens are minted to, the
TransferandTransferRangeevents that fire will show them as being minted tomsg.sender:https://github.com/iamdefinitelyahuman/ZAP-Tech/blob/62f8434e9033a930f61e3ddb968a5ecd227ef535/contracts/NFToken.sol#L373-L374
How to Fix
Change
msg.senderto_ownerin the above lines, and maybe add some unit tests to check the correctness of the events being fired.