search

zeromicro / go-zero

A cloud-native Go microservices framework with cli tool for productivity.
https://go-zero.dev
MIT License
29.34k stars 3.96k forks source link

feat: add ProcConf to make SetTimeToForceQuit configurable #4446

Open WqyJh opened 2 weeks ago

WqyJh commented 2 weeks ago

Add ProcConf to ServiceConf, then we can use config file instead of SetTimeToForceQuit to set force quit time.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.54%. Comparing base (8690859) to head (54bae6e). Report is 159 commits behind head on master.

Additional details and impacted files | [Files with missing lines](https://app.codecov.io/gh/zeromicro/go-zero/pull/4446?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zeromicro) | Coverage Δ | | |---|---|---| | [core/proc/shutdown.go](https://app.codecov.io/gh/zeromicro/go-zero/pull/4446?src=pr&el=tree&filepath=core%2Fproc%2Fshutdown.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zeromicro#diff-Y29yZS9wcm9jL3NodXRkb3duLmdv) | `75.51% <100.00%> (+1.59%)` | :arrow_up: | | [core/service/serviceconf.go](https://app.codecov.io/gh/zeromicro/go-zero/pull/4446?src=pr&el=tree&filepath=core%2Fservice%2Fserviceconf.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zeromicro#diff-Y29yZS9zZXJ2aWNlL3NlcnZpY2Vjb25mLmdv) | `90.32% <100.00%> (+0.32%)` | :arrow_up: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/zeromicro/go-zero/pull/4446/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zeromicro)
WqyJh commented 1 week ago

Could this simple patch be merged? @kevwan