search

zeromq / azmq

C++ language binding library integrating ZeroMQ with Boost Asio
Boost Software License 1.0
318 stars 108 forks source link

message's rebuild() function is not consistent with ctor #115

Closed oliora closed 9 years ago

oliora commented 9 years ago

I propose to either update message::rebuild() so it has the same overloads as ctor or remove it completely because user can do assignment if needs to rebuild the message. Due to large amount of overloads, latter approach looks more simple.

UPD: I would also consider to rename rebuild() into more standard reset().

rodgert commented 9 years ago

Remove seems best.

On Monday, September 28, 2015, Andrey Upadyshev notifications@github.com wrote:

I propose to either update message::rebuild() so it has the same overloads as ctor or remove it completely because user can do assignment if needs to rebuild the message. Due to large amount of overloads, latter approach looks more simple.

— Reply to this email directly or view it on GitHub https://github.com/zeromq/azmq/issues/115.