search

zeromq / azmq

C++ language binding library integrating ZeroMQ with Boost Asio
Boost Software License 1.0
319 stars 109 forks source link

Pull request for #138 Boost 1.48 compatibility #140

Closed mbasunov closed 6 years ago

mbasunov commented 6 years ago

Modifying mutex reference Conditional define for BOOST_SYSTEM_NOEXCEPT Conditional drop of string_ref reference Option to disable tests which aren't adopted for older boost Removed Boost log component reference in find_package Decreased Boost version requirement in find_package.

rodgert commented 6 years ago

Any chance you could squash this to a single commit?

rodgert commented 6 years ago

I’m fine with just including locks.hpp then, and not making it conditional.

On Thu, Feb 1, 2018 at 1:31 PM mbasunov notifications@github.com wrote:

@mbasunov commented on this pull request.

In azmq/detail/context_ops.hpp https://github.com/zeromq/azmq/pull/140#discussion_r165463301:

@@ -15,7 +15,8 @@

include <boost/assert.hpp>

include <boost/system/error_code.hpp>

include <boost/thread/mutex.hpp>

-#include <boost/thread/lock_guard.hpp> +#include <boost/thread/locks.hpp>

string_ref in socket_ops also optional, removing with conditional include.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/zeromq/azmq/pull/140#discussion_r165463301, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHYB_RccvySZQiSXPkD28vk2WQUGjk2ks5tQhEUgaJpZM4R1evn .

mbasunov commented 6 years ago

Squashed.