Closed jcfr closed 4 years ago
Looks good to me, will have to wait for @sigiesec for approval.
Looks good to me, will have to wait for @sigiesec for approval.
Sounds good. Thanks again for your help :pray:
Let me know if you need anything else.
The travis error also seems unrelated:
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package g++-9
E: Couldn't find any package by regex 'g++-9'
apt-get.diagnostics
apt-get install failed
The command "sudo -E apt-get -yq --no-install-suggests --no-install-recommends $(travis_apt_get_options) install g++-9 clang-8" failed and exited with 100 during .
See https://travis-ci.org/github/zeromq/cppzmq/jobs/683591543
Thanks for fixing this!
Yes, the travis failure was an infrastructure issue, it went away after retriggering the job.
This commit fixes a regression introduced in a3e5b54c3 (Problem: Socket options lack type-safety (#393)).
It addresses the following error reported when building the project on macOS 10.11.6.
Errors like the following:
Compiler version:
Similar issues:
https://github.com/tensorflow/tensorflow/issues/28839 error: default initialization of an object of const type 'const Subgraph::Identity' without a user-provided default constructor
https://bugzilla.mozilla.org/show_bug.cgi?id=1451088 Clang 3.8: error: default initialization of an object of const type 'const js::jit::ArithPolicy' without a user-provided default constructor
https://github.com/googleapis/google-cloud-cpp/issues/1593 [osx] error: default initialization of an object of const type