search

zeromq / cppzmq

Header-only C++ binding for libzmq
http://www.zeromq.org
MIT License
1.95k stars 757 forks source link

Problem: buffer definitions after message_t #418

Closed gummif closed 4 years ago

gummif commented 4 years ago

Soluion: move buffer definitions to a more logic location

gummif commented 4 years ago

This was part of a previous change that added constructors to message_t that take buffer related to deprecating another ctor. Yes, the diff looks bad, but it is just a simple move. Should I try to split this into smaller commits that might look better individually?

sigiesec commented 4 years ago

I think this shouldn't be done. Splitting it up into smaller commits might be slightly better, but doesn't change the fundamental problem that this breaks blameing without a significant benefit. We might do a big re-haul of the file at some point of time, but then the structure of the whole file should be rethought.

gummif commented 4 years ago

OK I will close this for now and work on the other PR without using the zmq::buffer overloads, since those are not really required for that change.