Fixes https://github.com/zeromq/cppzmq/issues/361, by incorperating F…

Cazadorro commented 3 years ago

Fixes https://github.com/zeromq/cppzmq/issues/361, by incorperating Ferdnyc's changes in OpenShot/libopenshot, previously cppzmq was not looking for the correct names, and rejected valid static library names when looking for zmq on windows, this fix aims to include those other names.

I've only tested this under zmq from VCPKG with the static target triplet, it would be good for someone to test this against non static target to make sure this doesn't break anything that worked before (I can't test that on my end).

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 1076079134

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.838%

Totals
Change from base Build 1045139778:	0.0%
Covered Lines:	794
Relevant Lines:	925

💛 - Coveralls

gummif commented 3 years ago

Does this work for static-only libzmq (is that an option even)?

gummif commented 3 years ago

I will just merge this now, looks like everything works in the CI.

zeromq / cppzmq

Fixes https://github.com/zeromq/cppzmq/issues/361, by incorperating F… #510

Pull Request Test Coverage Report for Build 1076079134

💛 - Coveralls