zeromq / cppzmq

Header-only C++ binding for libzmq
http://www.zeromq.org
MIT License
1.94k stars 757 forks source link

ZMQ_DEPRECATED doesn't fallback for unrecognized compiler #515

Closed ashish-17 closed 2 years ago

ashish-17 commented 2 years ago

If you use a compiler outside of _MSC_VER and _GNUC__, then the if-else check doesn't provide a fallback for ZMQ_DEPRECATED macro which leads to a build failure. Specifically in my case , I am using Oracle's SunPro 5.13.0.

My suggestions is to fallback to noop in case you don't recognize a compiler. Addressed #516

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1242586826


Totals Coverage Status
Change from base Build 1226642419: 0.0%
Covered Lines: 801
Relevant Lines: 931

💛 - Coveralls
gummif commented 2 years ago

Thanks for that.