zeromq / cppzmq

Header-only C++ binding for libzmq
http://www.zeromq.org
MIT License
1.93k stars 757 forks source link

Remove ENABLE_DRAFTS option #565

Closed stephanlachnit closed 2 weeks ago

stephanlachnit commented 2 years ago

This option added ZMQ_BUILD_DRAFT_API to the compile definitions. However, this should be propagated by libzmq (see https://github.com/zeromq/libzmq/pull/4323 and https://github.com/zeromq/cppzmq/issues/477).

Closes https://github.com/zeromq/cppzmq/issues/477.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 6957349874


Files with Coverage Reduction New Missed Lines %
zmq.hpp 6 82.88%
<!-- Total: 6 -->
Totals Coverage Status
Change from base Build 6697216186: -0.6%
Covered Lines: 848
Relevant Lines: 982

💛 - Coveralls
gummif commented 2 years ago

This change will probably break something for someone using slightly older versions of libzmq.

stephanlachnit commented 2 years ago

This change will probably break something for someone using slightly older versions of libzmq.

Yes, I would recommend merging this change only after a new release of libzmq (the commit in question is not part of a release yet), since it is fairly reasonable to expect people not to take a new version of cppzmq and an old version libzmq.

stephanlachnit commented 9 months ago

@gummif since libzmq v4.3.5 has been released with https://github.com/zeromq/libzmq/issues/4194 included, this can merged now

stephanlachnit commented 9 months ago

I also updated the CI to use 4.3.5. to actually use this change.

gummif commented 8 months ago

Sorry for the delay. I will see if I have time soon to do a review.

stephanlachnit commented 4 months ago

@gummif friendly ping to check this :) This is quite a small change

gummif commented 2 weeks ago

OK I think this looks good. In the unlikely scenario someone has problem with enabling drafts (using older version of libzmq built with drafts and new version of cppzmq) they just need to add target_compile_definitions(${target} PUBLIC ZMQ_BUILD_DRAFT_API) to their cmake project.