search

zeromq / czmq

High-level C binding for ØMQ
czmq.zeromq.org
Mozilla Public License 2.0
1.16k stars 523 forks source link

installed header conflict #2197

Open mrpelotazo opened 2 years ago

mrpelotazo commented 2 years ago

Hey there,

I'm getting a conflict with header sha1.h when attempting to install czmq built with cmake from current master. The header is already present as part of another package.

This is not the case when built with autogen/configure.

I've noticed that the files installed under include differ between the two build methods. It looks to me that the extra file sin the cmake variant should probably not be installed (?):

$ diff -y include-autogen include-cmake 
czmq.h                                                          czmq.h
czmq_library.h                                                  czmq_library.h
czmq_prelude.h                                                  czmq_prelude.h
                                                              > readme.txt
                                                              > sha1.h
                                                              > sha1.inc_c
                                                              > slre.h
                                                              > slre.inc_c
zactor.h                                                        zactor.h
zargs.h                                                         zargs.h
zarmour.h                                                       zarmour.h
zauth.h                                                         zauth.h
zbeacon.h                                                       zbeacon.h
zcert.h                                                         zcert.h
zcertstore.h                                                    zcertstore.h
zchunk.h                                                        zchunk.h
zclock.h                                                        zclock.h
zconfig.h                                                       zconfig.h
zdigest.h                                                       zdigest.h
zdir.h                                                          zdir.h
zdir_patch.h                                                    zdir_patch.h
zfile.h                                                         zfile.h
zframe.h                                                        zframe.h
                                                              > zgossip_engine.inc
zgossip.h                                                       zgossip.h
                                                              > zgossip_msg.h
zhash.h                                                         zhash.h
                                                              > zhash_primes.inc
zhashx.h                                                        zhashx.h
zhttp_client.h                                                  zhttp_client.h
zhttp_request.h                                                 zhttp_request.h
zhttp_response.h                                                zhttp_response.h
zhttp_server.h                                                  zhttp_server.h
zhttp_server_options.h                                          zhttp_server_options.h
ziflist.h                                                       ziflist.h
zlist.h                                                         zlist.h
zlistx.h                                                        zlistx.h
zloop.h                                                         zloop.h
zmonitor.h                                                      zmonitor.h
zmsg.h                                                          zmsg.h
zosc.h                                                          zosc.h
zpoller.h                                                       zpoller.h
zproc.h                                                         zproc.h
zproxy.h                                                        zproxy.h
zrex.h                                                          zrex.h
zsock.h                                                         zsock.h
                                                              > zsock_option.inc
zstr.h                                                          zstr.h
zsys.h                                                          zsys.h
ztimerset.h                                                     ztimerset.h
ztrie.h                                                         ztrie.h
zuuid.h                                                         zuuid.h
bluca commented 2 years ago

yeah cmake is wrong - can you fix it in https://github.com/zeromq/zproject/blob/master/zproject_cmake.gsl and send a PR?

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity for 90 days. It will be closed if no further activity occurs within 21 days. Thank you for your contributions.

BillyONeal commented 2 years ago

https://github.com/microsoft/vcpkg/pull/24433 This just happened in vcpkg too :).

I don't understand "zproject" in order to fix it, but I can just delete the files produced before we install them.