search

zeromq / czmq

High-level C binding for ØMQ
czmq.zeromq.org
Mozilla Public License 2.0
1.18k stars 525 forks source link

Problem: Documentation shows invalid links. #2235

Closed stephan57160 closed 2 years ago

stephan57160 commented 2 years ago

git clone git://gihub.com no more supported:

prompt> grep 'git://github.com' README.md
    git clone git://github.com/zeromq/libzmq.git
    git clone git://github.com/zeromq/czmq.git
git clone git://github.com/zeromq/libzmq.git
git clone git://github.com/zeromq/czmq.git
    git clone git://github.com/zeromq/libzmq.git
    git clone git://github.com/zeromq/czmq.git
prompt> git clone git://github.com/zeromq/libzmq.git
Cloning into 'libzmq'...
fatal: unable to connect to github.com:
github.com[0: 140.82.121.3]: errno=Connection timed out

prompt>

Solution: Change all git://github.com with https://github.com. See also https://github.com/zeromq/libzmq/pull/4427 for reference.

Pull Request Notice

Before sending a pull request make sure each commit solves one clear, minimal, plausible problem. Further each commit should have the following format:

Problem: X is broken

Solution: do Y and Z to fix X

Please avoid sending a pull request with recursive merge nodes, as they are impossible to fix once merged. Please rebase your branch on zeromq/czmq master instead of merging it.

git remote add upstream git@github.com:zeromq/czmq.git git fetch upstream git rebase upstream/master git push -f

In case you already merged instead of rebasing you can drop the merge commit.

git rebase -i HEAD~10

Now, find your merge commit and mark it as drop and save. Finally rebase!

If you are a new contributor please have a look at our contributing guidelines: CONTRIBUTING.md