zeromq / czmq

High-level C binding for ØMQ
czmq.zeromq.org
Mozilla Public License 2.0
1.16k stars 523 forks source link

Problem: More invalid links to git://github.com #2236

Closed stephan57160 closed 1 year ago

stephan57160 commented 1 year ago

Following https://github.com/zeromq/czmq/pull/2235, I checked deeper and found some more such references:

prompt> cd czmq
prompt> find . -type f | grep -v '/.git/' | xargs grep 'git://github.com'
./.circleci/config.yml:            git clone --depth 1 --quiet git://github.com/sappo/czmq.git "$Env:CZMQ_DIR"
./builds/stable_zmq/ci_build.sh:    git clone --quiet --depth 1 -b stable git://github.com/jedisct1/libsodium.git
./doc/czmq.txt:    git clone git://github.com/zeromq/czmq.git
prompt>

Solution: Fix invalid git://github.com URLs.

Note: Similar task in progress in ZYRE.

Pull Request Notice

Before sending a pull request make sure each commit solves one clear, minimal, plausible problem. Further each commit should have the following format:

Problem: X is broken

Solution: do Y and Z to fix X

Please avoid sending a pull request with recursive merge nodes, as they are impossible to fix once merged. Please rebase your branch on zeromq/czmq master instead of merging it.

git remote add upstream git@github.com:zeromq/czmq.git git fetch upstream git rebase upstream/master git push -f

In case you already merged instead of rebasing you can drop the merge commit.

git rebase -i HEAD~10

Now, find your merge commit and mark it as drop and save. Finally rebase!

If you are a new contributor please have a look at our contributing guidelines: CONTRIBUTING.md