search

zeromq / ingescape

Model-based framework for broker-free distributed software environments. Any language, any OS, web, cloud.
Other
61 stars 14 forks source link

Fix default agent created even if not needed. resolve #25 #26

Closed Fafou closed 2 years ago

Fafou commented 2 years ago

Try to fix issue: https://github.com/zeromq/ingescape/issues/25

I added test on igsTester to highlight the issue.

The fix consist on adding platform_name in igs context, initialize to zyre_node name. Its Value is agent name in case of using default agent from igs, or zyre_node uuid in case of multi igs agent.

If you agree with the issue, maybe you want to discuss about the function admin_log from ingescape_private.h, because now I change the interface. I can keep the old function, who will call the new one.

stvales commented 2 years ago

This MR introduces an API modification and changes internal behaviors towards the core agent which has a specific role and is mandatory. A correction has been pushed which resolves the crash itself.

Fafou commented 2 years ago

Ok thanks for your explanation. It can be good to take my changes on tester.c to add unit test on this special case to avoid regression in futur ?