search

zeromq / jeromq-jms

JeroMQ JMS
25 stars 13 forks source link

Allow double-quotes as literal terms #6

Closed scoheb closed 7 years ago

scoheb commented 7 years ago

Thanks! Can we create a release with this fix?

mjeremym commented 7 years ago

Sure,

Minor release.

Try to night, if not this weekend

Going to release 2.0 for the upgrade to Jeromq 0.4 and JMS 2.1 but it may take a wee bit longer.

Regards Jeremy

Sent from my iPhone

On 29 Mar 2017, at 22:50, Scott Hebert notifications@github.com wrote:

Thanks! Can we create a release with this fix?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

scoheb commented 7 years ago

Minor release would be great! Tx

scoheb commented 7 years ago

Can you please let me know when it is available please? I need to release https://github.com/jenkinsci/jms-messaging-plugin/pull/21/ Thanks!

mjeremym commented 7 years ago

Will do. Need to be done at home. Blocked at work

Jeremy

Sent from my iPhone

On 30 Mar 2017, at 14:54, Scott Hebert notifications@github.com wrote:

Can you please let me know when it is available please? I need to release jenkinsci/jms-messaging-plugin#21/ Thanks!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

mjeremym commented 7 years ago

done

On 30 Mar 2017, at 14:54, Scott Hebert notifications@github.com wrote:

Can you please let me know when it is available please? I need to release jenkinsci/jms-messaging-plugin#21 https://github.com/jenkinsci/jms-messaging-plugin/pull/21/ Thanks!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/zeromq/jeromq-jms/pull/6#issuecomment-290417837, or mute the thread https://github.com/notifications/unsubscribe-auth/AHOnwEnOiJxvjWxu5kHmR9zBzLPDMDvfks5rq7QegaJpZM4MthIE.

scoheb commented 7 years ago

Seems like this release is a bit different. I am now getting this while build my project:

[INFO] Restricted to JDK 1.7 yet org.zeromq:jeromq-jms:jar:1.1.1-RELEASE:compile contains org/zeromq/jms/protocol/redelivery/ZmqRedeliveryPolicy.class targeted to JDK 1.8
[WARNING] Rule 2: org.apache.maven.plugins.enforcer.EnforceBytecodeVersion failed with message:
Found Banned Dependency: org.zeromq:jeromq-jms:jar:1.1.1-RELEASE

Can this be rebuild with JDK 1.7?

mjeremym commented 7 years ago

Let me look at it tonight

I had switch to java 8 for version 2 and swapped branches in the ide. Let me do it work lest haste this time Sorry Jeremy

Sent from my iPhone

On 31 Mar 2017, at 02:35, Scott Hebert notifications@github.com wrote:

Seems like this release is a bit different. I am now getting this while build my project:

[INFO] Restricted to JDK 1.7 yet org.zeromq:jeromq-jms:jar:1.1.1-RELEASE:compile contains org/zeromq/jms/protocol/redelivery/ZmqRedeliveryPolicy.class targeted to JDK 1.8 [WARNING] Rule 2: org.apache.maven.plugins.enforcer.EnforceBytecodeVersion failed with message: Found Banned Dependency: org.zeromq:jeromq-jms:jar:1.1.1-RELEASE

Can this be rebuild with JDK 1.7?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

mjeremym commented 7 years ago

Hello,

I have fix up my POM (to include the enforcer). I can only assume it was caused by my hard coding to JDK 1.8 for the tools and console.

I get no EnforceBytecodeVerison errors, which I did get before the fix.

It has been pushed to maven central as 1.1.1 again.

regards Jeremy

On 31 Mar 2017, at 11:22, Mr. Jeremy R N Miller mjeremym@gmail.com wrote:

Let me look at it tonight

I had switch to java 8 for version 2 and swapped branches in the ide. Let me do it work lest haste this time Sorry Jeremy

Sent from my iPhone

On 31 Mar 2017, at 02:35, Scott Hebert <notifications@github.com mailto:notifications@github.com> wrote:

Seems like this release is a bit different. I am now getting this while build my project:

[INFO] Restricted to JDK 1.7 yet org.zeromq:jeromq-jms:jar:1.1.1-RELEASE:compile contains org/zeromq/jms/protocol/redelivery/ZmqRedeliveryPolicy.class targeted to JDK 1.8 [WARNING] Rule 2: org.apache.maven.plugins.enforcer.EnforceBytecodeVersion failed with message: Found Banned Dependency: org.zeromq:jeromq-jms:jar:1.1.1-RELEASE

Can this be rebuild with JDK 1.7?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/zeromq/jeromq-jms/pull/6#issuecomment-290591624, or mute the thread https://github.com/notifications/unsubscribe-auth/AHOnwAND792dRJ31iQcrMGf2-9OCzjhkks5rrFhegaJpZM4MthIE.

scoheb commented 7 years ago

I will give it a try shortly! thanks!

scoheb commented 7 years ago

Seems like the maven repos that I use for dependencies have cached the old 1.1.1 release. I see the correct one here though: https://repo.maven.apache.org/maven2/org/zeromq/jeromq-jms/1.1.1-RELEASE/jeromq-jms-1.1.1-RELEASE.jar

Would you have able to release 1.1.2 so that the repos are refreshed? The only change would be the pom version.

Thanks!

mjeremym commented 7 years ago

Sure I'll do it tonight Jeremy

Sent from my iPhone

On 5 Apr 2017, at 13:47, Scott Hebert notifications@github.com wrote:

Seems like the maven repos that I use for dependencies have cached the old 1.1.1 release. I see the correct one here though: https://repo.maven.apache.org/maven2/org/zeromq/jeromq-jms/1.1.1-RELEASE/jeromq-jms-1.1.1-RELEASE.jar

Would you have able to release 1.1.2 so that the repos are refreshed? The only change would be the pom version.

Thanks!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

mjeremym commented 7 years ago

OK 1.1.2 has been released.

Let me know if you have any issues.

regards Jeremy

On 5 Apr 2017, at 13:47, Scott Hebert notifications@github.com wrote:

Seems like the maven repos that I use for dependencies have cached the old 1.1.1 release. I see the correct one here though: https://repo.maven.apache.org/maven2/org/zeromq/jeromq-jms/1.1.1-RELEASE/jeromq-jms-1.1.1-RELEASE.jar https://repo.maven.apache.org/maven2/org/zeromq/jeromq-jms/1.1.1-RELEASE/jeromq-jms-1.1.1-RELEASE.jar Would you have able to release 1.1.2 so that the repos are refreshed? The only change would be the pom version.

Thanks!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/zeromq/jeromq-jms/pull/6#issuecomment-291850467, or mute the thread https://github.com/notifications/unsubscribe-auth/AHOnwHxOTBBu3ImKKZYtc1yxHb0X_NXaks5rs41dgaJpZM4MthIE.

scoheb commented 7 years ago

Still not seeing it here: http://repo.jenkins-ci.org/public/org/zeromq/jeromq-jms/ or here http://repo.maven.apache.org/maven2/org/zeromq/jeromq-jms/

I will wait and see if it appears.

mjeremym commented 7 years ago

odd, it on nexus as released

https://oss.sonatype.org/#nexus-search;quick~jeromq-jms https://oss.sonatype.org/#nexus-search;quick~jeromq-jms

org.zeromq jeromq-jms 1.1.2-RELEASE

I’ll check later. On the weekend it was fast. Not on maven central yet

Jeremy

On 5 Apr 2017, at 19:41, Scott Hebert notifications@github.com wrote:

Still not seeing it here: http://repo.jenkins-ci.org/public/org/zeromq/jeromq-jms/ http://repo.jenkins-ci.org/public/org/zeromq/jeromq-jms/ or here http://repo.maven.apache.org/maven2/org/zeromq/jeromq-jms/ http://repo.maven.apache.org/maven2/org/zeromq/jeromq-jms/ I will wait and see if it appears.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/zeromq/jeromq-jms/pull/6#issuecomment-291956688, or mute the thread https://github.com/notifications/unsubscribe-auth/AHOnwC0p9PQbqI7vZP1q9J_D14nJxzgJks5rs-BTgaJpZM4MthIE.

scoheb commented 7 years ago

All good now!

On Wed, Apr 5, 2017, 15:03 Jeremy Miller notifications@github.com wrote:

odd, it on nexus as released

https://oss.sonatype.org/#nexus-search;quick~jeromq-jms < https://oss.sonatype.org/#nexus-search;quick~jeromq-jms>

org.zeromq jeromq-jms 1.1.2-RELEASE

I’ll check later. On the weekend it was fast. Not on maven central yet

Jeremy

On 5 Apr 2017, at 19:41, Scott Hebert notifications@github.com wrote:

Still not seeing it here: http://repo.jenkins-ci.org/public/org/zeromq/jeromq-jms/ < http://repo.jenkins-ci.org/public/org/zeromq/jeromq-jms/> or here http://repo.maven.apache.org/maven2/org/zeromq/jeromq-jms/ < http://repo.maven.apache.org/maven2/org/zeromq/jeromq-jms/> I will wait and see if it appears.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub < https://github.com/zeromq/jeromq-jms/pull/6#issuecomment-291956688>, or mute the thread < https://github.com/notifications/unsubscribe-auth/AHOnwC0p9PQbqI7vZP1q9J_D14nJxzgJks5rs-BTgaJpZM4MthIE .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zeromq/jeromq-jms/pull/6#issuecomment-291963169, or mute the thread https://github.com/notifications/unsubscribe-auth/ADbhp07vzTzzbnBRPoMMSfF1UJP-IRD_ks5rs-WHgaJpZM4MthIE .