Code refactoring implemented to remove smells

zeromq / jeromq

Pure Java ZeroMQ

Mozilla Public License 2.0

2.34k stars 484 forks source link

Code refactoring implemented to remove smells #952

Closed piyush-akoliya closed 10 months ago

piyush-akoliya commented 1 year ago

Implemented following code refactoring techniques: Extract method Decompose conditional Introduce explaining variable

Move method Pull-up variable Extract class

fbacchella commented 1 year ago

Did you run a mvn compile -Pcheckstyle on your code ? I don’t think so.

trevorbernard commented 1 year ago

This PR is doing way too much. I'm still unclear what problems it aims to solve. As @fbacchella we already mentioned we have a coding style that jeromq uses.