zeromq / libzmq

ZeroMQ core engine in C++, implements ZMTP/3.1
https://www.zeromq.org
Mozilla Public License 2.0
9.64k stars 2.35k forks source link

Visual Studio 2013 Debug builds with libsodium are failing test_security_curve #3210

Closed sigiesec closed 4 years ago

sigiesec commented 6 years ago

Issue description

The test case test_security_curve fails due to a heap corruption.

Environment

Minimal test code / Steps to reproduce the issue

  1. Build with Visual Studio 2013 and libsodium
  2. Run test_security_curve

What's the actual result? (include assertion message & call stack if applicable)

68: Test command: C:\projects\build_libzmq\bin\Debug\test_security_curve.exe
68: Test timeout computed to be: 60
68: f:\dd\vctools\crt\crtw32\misc\dbgheap.c(1328) : Assertion failed: _BLOCK_TYPE_IS_VALID(pHead->nBlockUse)
64/81 Test #68: test_security_curve ..............***Exception: SegFault  0.03 sec

cf. https://ci.appveyor.com/project/zeromq/libzmq/build/build-2491/job/ynbe789n221wgooi#L1325

What's the expected result?

No failure.

bluca commented 6 years ago

How did that commit affect the libsodium run?

sigiesec commented 6 years ago

Maybe it was failing already before, but the previous build was fine. Maybe just a coincidence.

The commit did not change any relevant code at all, and libsodium did not change either at that time.

sigiesec commented 6 years ago

I cannot reproduce it with VS2017 locally :(

bluca commented 6 years ago

Do you see anything that could have changed how cmake is configured in those cases? It's a bit hard to read

bluca commented 5 years ago

@sigiesec any chance you've got time to look at this? Given the TIPC one is fixed now, I think this is the only blocker for a new release

sigiesec commented 5 years ago

I will try to look at it in the next days, but I cannot promise, sorry!

sigiesec commented 5 years ago

Finally I made some progress, I installed VS2013. Will give the failing test a look tomorrow.

sigiesec commented 5 years ago

Unfortunately, I cannot reproduce the problems with VS2013 on my machine either :(

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had activity for 365 days. It will be closed if no further activity occurs within 56 days. Thank you for your contributions.