zeromq / libzmq

ZeroMQ core engine in C++, implements ZMTP/3.1
https://www.zeromq.org
Mozilla Public License 2.0
9.71k stars 2.35k forks source link

Problem: bind can fail after open_socket succeeds on Windows without AF_UNIX #4422

Closed minrk closed 2 years ago

minrk commented 2 years ago

closes #4386

Following discussion in #4386, this is a more specific check requested by @bluca rather than a catch-all. Only failures up to the initial bind are considered for fallback to tcpip.

I can't reproduce the error, so I don't know exactly what errno to check for to make the condition even more specific.

Also adds the missing check of the returned rc from make_fd_pair, which should have raised the actual error instead of the cryptic src\epoll.cpp:100 reported in https://github.com/zeromq/pyzmq/issues/1505