zeromq / libzmq

ZeroMQ core engine in C++, implements ZMTP/3.1
https://www.zeromq.org
Mozilla Public License 2.0
9.71k stars 2.35k forks source link

Problem: Android NDK 22 download broken since support of NDK 23. #4444

Closed stephan57160 closed 2 years ago

stephan57160 commented 2 years ago

Due to the PR to support NDK 23.

With NDK 23, the archive file name has changed. This change is handled by the PR to support NDK23, but now, only 23 and after are supported.

Also, NDK 23 support introduced a 2nd occurence of the variable HOST_PLATFORM, with another value. One occurence being exported, this may confuse next developpers (and it actually confused me).

Solution: Code review

1st occurence is simply dropped, and the algorithm around is changed so that there is no need of a 'host_platform' kind of stuff.

2nd occurrence is renamed to ANDROID_BUILD_PLATFORM.

Note that 'HOST' is replaced by 'BUILD', as this is the common naming when talking about the build/compilation machine, when cross compiling.

A dedicated function is created in the helpers, to actually download the NDK. As this function is made 'public', more checks are performed.

Note:

To be reported in CZMQ & ZYRE, via ZPROJECT, where NDK is downloaded in 2 different files.