Switch to CNG instead of the deprecated WinCrypt

zeromq / libzmq

ZeroMQ core engine in C++, implements ZMTP/3.1

https://www.zeromq.org

Mozilla Public License 2.0

9.62k stars 2.35k forks source link

Switch to CNG instead of the deprecated WinCrypt #4519

Closed madamantis-leviathan closed 1 year ago

madamantis-leviathan commented 1 year ago

Since wincrypt.h is deprecated, I replaced it with BCryptGenRandom from Cryptography Next Generation API (CNG).

I tried to follow the existing code style so as not to break anything. However, the changes that I made to CMakeLists.txt to include the new library (bcrypt.lib) don't appear to have had any effect. Feedback would be really appreciated

bluca commented 1 year ago

I'm not a windows user so can't help with this, we'll need to wait for somebody who knows their way around it

bluca commented 1 year ago

tweetnacl was dropped in https://github.com/zeromq/libzmq/pull/4554 and is not going to come back, so we won't need this change anymore.