search

zeromq / libzmq

ZeroMQ core engine in C++, implements ZMTP/3.1
https://www.zeromq.org
Mozilla Public License 2.0
9.62k stars 2.35k forks source link

Problem: merged pr-4432 broke FindSodium on linux #4542

Closed bjornstromberg closed 1 year ago

bjornstromberg commented 1 year ago

Solution: rename the FindSodium to Findsodium so it matches what the build script actually looks for. tested on ubuntu-20.04lts with cmake 3.16.

bjornstromberg commented 1 year ago

4432 just to link these

bjornstromberg commented 1 year ago

the ci failure on the github actions ci is just a long running test that timed out 70/101 Test #70: test_security_curve ..............***Timeout 60.01 sec

on master 70/101 Test #70: test_security_curve .............. Passed 11.74 sec

that is a pretty bad change, is this normal on github actions that stuff times out? thinking load on server could be a big factor since everything else seems to have passed.

and no code is actually changed just a filename..