zeromq / libzmq

ZeroMQ core engine in C++, implements ZMTP/3.1
https://www.zeromq.org
Mozilla Public License 2.0
9.67k stars 2.35k forks source link

endpoint.hpp throws a compiler warning due to `const bool` return #4629

Closed nehalkpatel closed 10 months ago

nehalkpatel commented 10 months ago

https://github.com/zeromq/libzmq/blame/814dab58a4eea3202d28d7db4fa24c27287c5378/src/endpoint.hpp#L32

Since bool is returned by value, the const is redundant and will throw an ignored-qualifier warning with clang:

[build] build/host/_deps/zeromq-src/src/endpoint.hpp:32:5: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers]
[build]    32 |     const bool clash () const { return local == remote; }
[build]       |     ^~~~~