zeromq / libzmq

ZeroMQ core engine in C++, implements ZMTP/3.1
https://www.zeromq.org
Mozilla Public License 2.0
9.53k stars 2.34k forks source link

Problem: macos-latest CIs both failing #4701

Closed fanquake closed 3 weeks ago

fanquake commented 3 weeks ago

Solution: Install libtool. This seems to be the issue, given the CI output of a recent run, i.e:

 configure.ac:1023: the top level
configure.ac:80: error: possibly undefined macro: AC_LIBTOOL_WIN32_DLL
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
configure.ac:81: error: possibly undefined macro: AC_PROG_LIBTOOL
configure:7350: error: possibly undefined macro: AC_DISABLE_STATIC
configure:7354: error: possibly undefined macro: AC_ENABLE_STATIC
autoreconf: error: /opt/homebrew/Cellar/autoconf/2.72/bin/autoconf failed with exit status: 1
autogen.sh: error: autoreconf exited with status 1
+ exit 1

For example, a CI run from the recent opened #4699: https://github.com/zeromq/libzmq/actions/runs/9841129190/job/27167025854?pr=4699#step:12:200.

fanquake commented 3 weeks ago

Now that the CIs are running, looks like there's at least one other failure. i.e https://github.com/zeromq/libzmq/actions/runs/9841741306/job/27169057898?pr=4701#step:12:1374:

 ../../src/curve_mechanism_base.hpp:9:10: fatal error: 'sodium.h' file not found
#include "sodium.h"
         ^~~~~~~~~~
ld: warning: -bind_at_load is deprecated on macOS
ld: warning: search path '/Users/runner/work/libzmq/libzmq/libzmq/tmp/lib' not found
ld: warning: -bind_at_load is deprecated on macOS
ld: warning: search path '/Users/runner/work/libzmq/libzmq/libzmq/tmp/lib' not found
1 error generated.