use rawset when initializing child thread args

zeromq / lzmq

Lua binding to ZeroMQ

MIT License

136 stars 46 forks source link

use rawset when initializing child thread args #34

Closed johnfoconnor closed 9 years ago

johnfoconnor commented 9 years ago

it is possible for someone to mess with the global table in the prelude or lua_init phases of thread creation. For instance, one could disable the creation of global variables via the _G __newindex metatable method. Then the thread spawning code would not work correctly. For this reason we should not rely on normal insertion into _G and instead use rawset

buildhive commented 9 years ago

The ØMQ project » lzmq #52 FAILURE Looks like there's a problem with this pull request (what's this?)

coveralls commented 9 years ago

Coverage decreased (-0.03%) to 64.52% when pulling 322ab8627a8aa61a58938f9df945d1fdacf83136 on johnfoconnor:master into e1ca8e166f867a39960ec8ce6d5db00a9728c1db on zeromq:master.

coveralls commented 9 years ago

Coverage decreased (-0.03%) to 64.52% when pulling 322ab8627a8aa61a58938f9df945d1fdacf83136 on johnfoconnor:master into e1ca8e166f867a39960ec8ce6d5db00a9728c1db on zeromq:master.

coveralls commented 9 years ago

Coverage remained the same at 64.55% when pulling 322ab8627a8aa61a58938f9df945d1fdacf83136 on johnfoconnor:master into e1ca8e166f867a39960ec8ce6d5db00a9728c1db on zeromq:master.