zeromq / majordomo

Majordomo Project
Mozilla Public License 2.0
115 stars 52 forks source link

may be a bug #19

Closed chenbk85 closed 11 years ago

chenbk85 commented 12 years ago

hi, May be a bug in /libmdp/src/mdp_broker.c static void s_broker_worker_msg (broker_t self, zframe_t sender, zmsg_t *msg) { ... ... free (command); //! this only free, but not close message, should be zframe_destroy(&command)? zmsg_destroy (&msg); }

by the way, for worker/client commands, why not use one byte to instead of string(four bytes). And one time only use one zmq_msg_t may be better, which not need to malloc frequently.

ths

chen baokai

akitada commented 11 years ago

Fixed.