search

zeromq / majordomo

Majordomo Project
Mozilla Public License 2.0
115 stars 52 forks source link

Disconnecting worker from broker #45

Closed kevinoid closed 10 years ago

kevinoid commented 10 years ago

Forgive me if I've overlooked something, but it does not appear that the current implementation provides a way for workers to signal disconnection to the broker and that without an explicit disconnect, requests sent to the silently disconnected worker before heartbeat expiration will be lost.

Assuming this is correct, would it make sense to add such a function? I could certainly send a pull request for it. Would it be suitable as part of mdp_worker_destroy, or should it be explicitly callable (possibly with additional state in _mdp_worker_t for tracking/handling the disconnected state)?

hintjens commented 10 years ago

Sure, send a pull request for this. That'd be welcome.

On Sun, Dec 22, 2013 at 2:35 AM, Kevin Locke notifications@github.comwrote:

Forgive me if I've overlooked something, but it does not appear that the current implementation provides a way for workers to signal disconnection to the broker and that without an explicit disconnect, requests sent to the silently disconnected worker before heartbeat expiration will be lost.

Assuming this is correct, would it make sense to add such a function? I could certainly send a pull request for it. Would it be suitable as part of mdp_worker_destroy, or should it be explicitly callable (possibly with additional state in _mdp_worker_t for tracking/handling the disconnected state)?

— Reply to this email directly or view it on GitHubhttps://github.com/zeromq/majordomo/issues/45 .