search

zeromq / netmq

A 100% native C# implementation of ZeroMQ for .NET
Other
2.97k stars 746 forks source link

TCP accept filters not working #300

Closed drewnoakes closed 9 years ago

drewnoakes commented 9 years ago

The internal Options class builds up a list of TcpAcceptFilters which are never queried.

The TcpAddressMask.MatchAddress is also never called.

JamesWHurst commented 9 years ago

Yes - I saw that and added a TODO comment asking what's up with that (see my latest PR).

somdoron commented 9 years ago

I think the feature is not used, it was ported incorrectly from ZeroMQ so I removed it some time ago (it actually never worked).

I suggest to obsolete the Options, if somebody in the future will request the feature we can try and implement it.

On Mon, Mar 16, 2015 at 4:13 PM, James Hurst notifications@github.com wrote:

Yes - I saw that and added a TODO comment asking what's up with that (see my latest PR).

— Reply to this email directly or view it on GitHub https://github.com/zeromq/netmq/issues/300#issuecomment-81690025.

drewnoakes commented 9 years ago

Sounds good. Removed in 1549f3d.