How about changing attributes, [CanBeNull] in src/NetMQ/Msg.cs

zeromq / netmq

A 100% native C# implementation of ZeroMQ for .NET

Other

2.95k stars 744 forks source link

How about changing attributes, [CanBeNull] in src/NetMQ/Msg.cs #774

Closed moreal closed 5 years ago

moreal commented 5 years ago

In function Buffer.CopyBlock, if src or dst is null, then it raises ArgumentNullException. So I think this shouldn't be null. But in Msg.cs source, function Put() allow null by using [CanBeNull] Attribute. So I suggest how about using attribute [NotNull] not [CanBeNull]

somdoron commented 5 years ago

Make the pull request

moreal commented 5 years ago

Ok, I will make the pr as soon